Skip to content

drop invocation of redismod_cluster docker #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Jul 27, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

We don't currently use it for testing and it causes CI fail.

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Jul 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022

Codecov Report

Merging #2307 (2f8fb3a) into master (f665bd3) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2307      +/-   ##
==========================================
+ Coverage   92.05%   92.06%   +0.01%     
==========================================
  Files         109      109              
  Lines       28134    28134              
==========================================
+ Hits        25899    25902       +3     
+ Misses       2235     2232       -3     
Impacted Files Coverage Δ
tests/conftest.py 86.50% <0.00%> (-0.80%) ⬇️
redis/asyncio/connection.py 85.57% <0.00%> (+0.11%) ⬆️
tests/test_cluster.py 97.08% <0.00%> (+0.11%) ⬆️
tests/test_asyncio/test_cluster.py 97.42% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f665bd3...2f8fb3a. Read the comment docs.

@dvora-h dvora-h merged commit 48f5aca into redis:master Jul 27, 2022
@dvora-h dvora-h deleted the drop-redismod_cluster branch June 18, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants