Update GitHub Actions versions #2389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvora-h
reviewed
Sep 21, 2022
| @@ -31,9 +31,8 @@ jobs: | |||
| name: Code linters | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - name: install python | |||
There was a problem hiding this comment.
@akx Why did you remove the name?
There was a problem hiding this comment.
Not all of the actions/setup-python steps in the YAML files had a name beforehand, anyway.
I see no actual value in a longer YAML file with the only visible change being "install python" being shown instead of "Run actions/setup-python@v4" in logs.
| @@ -55,9 +54,8 @@ jobs: | |||
| ACTIONS_ALLOW_UNSECURE_COMMANDS: true | |||
| name: Python ${{ matrix.python-version }} ${{matrix.test-type}}-${{matrix.connection-type}} tests | |||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - name: install python | |||
| @@ -94,9 +92,8 @@ jobs: | |||
| matrix: | |||
| extension: ['tar.gz', 'whl'] | |||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - name: install python | |||
| @@ -110,9 +107,8 @@ jobs: | |||
| matrix: | |||
| python-version: ['3.7', '3.8', '3.9', '3.10', 'pypy-3.7'] | |||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - name: install python ${{ matrix.python-version }} | |||
dvora-h
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
This PR bumps various GitHub Actions versions to current ones.