Skip to content

FT.SEARCH: Fixing aggregation request argument for LIMIT #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Sep 21, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

fixes #2383

@dvora-h dvora-h added the bug Bug label Sep 21, 2022
@dvora-h dvora-h requested a review from chayim September 21, 2022 09:57
@chayim chayim changed the title Fix - aggregation request arguments for LIMIT Fixing aggregation request argument for LIMIT Sep 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Base: 92.25% // Head: 92.24% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (c2a376e) compared to base (947b8e8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2393      +/-   ##
==========================================
- Coverage   92.25%   92.24%   -0.02%     
==========================================
  Files         110      110              
  Lines       28906    28905       -1     
==========================================
- Hits        26668    26662       -6     
- Misses       2238     2243       +5     
Impacted Files Coverage Δ
redis/commands/search/aggregation.py 78.87% <100.00%> (-0.85%) ⬇️
tests/test_asyncio/test_cluster.py 97.28% <0.00%> (-0.14%) ⬇️
tests/test_cluster.py 96.96% <0.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chayim chayim changed the title Fixing aggregation request argument for LIMIT FT.SEARCH: Fixing aggregation request argument for LIMIT Sep 29, 2022
@dvora-h dvora-h merged commit fbf68dd into redis:master Sep 29, 2022
@lgnashold
Copy link

Thank you for fixing :)

@dvora-h dvora-h deleted the fix-search-limit branch June 18, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Aggregation Request Generates Incorrect Command Arguments for LIMIT
4 participants