Skip to content

Correct npm instructions in Intermediate Tutorial #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

roryokane
Copy link
Contributor

This makes the npm install command in the Intermediate Tutorial match the one in the Quick Start.

@netlify
Copy link

netlify bot commented Feb 2, 2020

Deploy preview for redux-starter-kit-docs ready!

Built with commit c86ec2a

https://deploy-preview-340--redux-starter-kit-docs.netlify.com

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c86ec2a:

Sandbox Source
aged-wave-my8uk Configuration
great-hertz-khyxc Configuration
rsk-github-issues-example Configuration

@markerikson
Copy link
Collaborator

I don't think the --save is really necessary these days. Can we flip it around and remove that from the "Getting Started" page instead?

@roryokane
Copy link
Contributor Author

Sure, I’ll do that.

I’ve been using Yarn so long I hadn’t known that npm had changed its behavior. Apparently that change was made for npm v5.0.0 in May 2017.

As of npm v5, `--save` is no longer necessary with `npm install`. Removing that flag makes the `npm install` command match the one given in the Intermediate Tutorial.
@roryokane roryokane force-pushed the fix-intermediate-tutorial-npm-install branch from a64c450 to c86ec2a Compare February 3, 2020 00:10
@roryokane roryokane changed the title Correct npm instructions in Intermediate Tutorial Simplify npm install instruction in Quick Start Feb 3, 2020
@markerikson markerikson changed the title Simplify npm install instruction in Quick Start Correct npm instructions in Intermediate Tutorial Feb 3, 2020
@markerikson markerikson merged commit 1774987 into reduxjs:master Feb 3, 2020
@markerikson
Copy link
Collaborator

Thanks!

@roryokane roryokane deleted the fix-intermediate-tutorial-npm-install branch February 3, 2020 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants