advanced tutorial update links from commit ids to tags #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for redux-starter-kit-docs ready! Built with commit ca14a6b https://deploy-preview-348--redux-starter-kit-docs.netlify.com |
phryneas
force-pushed
the
advanced-tutorial-update-links-to-tags
branch
from
7c3e295 to
e89e512
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7c3e295:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ca14a6b:
|
phryneas
force-pushed
the
advanced-tutorial-update-links-to-tags
branch
from
e89e512 to
ca14a6b
Compare
|
Sweet. Also need to update the sandbox URLs, but I'll do that momentarily |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the AppThunk example from
undefinedtounknownin the advanced tutorial. This updates all links in the tutorial accordingly, using the tags we talked about.This should work as soon as you force-push the current commit history from https://github.com/phryneas/rsk-github-issues-example/tree/change-appthunk-from-null-to-unknown over to the upstream repo and apply all the tags there.