Skip to content

[testlib] Make GPU burn test a library test #2503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 12, 2022

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented May 8, 2022

More particularly, this PR offers the following:

  • Converts the GPU burn test into a library test.
  • Bases the the CSCS test on this new library test.
  • Introduces new command line arguments to the GPU burn test itself, so as to control better its behavior.
  • Introduces a new source file organisation for the GPU microbenchmarks (currently, only the GPU burn test follows the new structure, but the rest of the tests will have to follow it as soon as they are updated).
  • The CSCS config is updated with metadata on its partitions and environments.
  • A new convenience method is added to the SystemPartition that allows to select the devices of a certain type.

@pep8speaks
Copy link

Hello @vkarak, Thank you for submitting the Pull Request!

Line 104:80: E501 line too long (83 > 79 characters)

Do see the ReFrame Coding Style Guide

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2022

Codecov Report

Merging #2503 (d4874bf) into master (cec5eee) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #2503      +/-   ##
==========================================
- Coverage   85.87%   85.86%   -0.01%     
==========================================
  Files          58       58              
  Lines       10775    10777       +2     
==========================================
+ Hits         9253     9254       +1     
- Misses       1522     1523       +1     
Impacted Files Coverage Δ
reframe/core/systems.py 89.49% <50.00%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cec5eee...d4874bf. Read the comment docs.

@vkarak vkarak requested a review from rsarm May 9, 2022 12:27
@vkarak vkarak added this to the ReFrame sprint 22.05.1 milestone May 9, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2503 (e08af94) into master (cec5eee) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #2503      +/-   ##
==========================================
- Coverage   85.87%   85.86%   -0.01%     
==========================================
  Files          58       58              
  Lines       10775    10777       +2     
==========================================
+ Hits         9253     9254       +1     
- Misses       1522     1523       +1     
Impacted Files Coverage Δ
reframe/core/systems.py 89.49% <50.00%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cec5eee...e08af94. Read the comment docs.

@vkarak vkarak requested review from teojgo and removed request for rsarm May 11, 2022 15:07
@vkarak vkarak merged commit b1b962d into reframe-hpc:master May 12, 2022
@vkarak vkarak deleted the testlib/gpuburn branch May 12, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants