Skip to content

Fix auth-with-shared-route example #3732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2016
Merged

Conversation

pleunv
Copy link
Contributor

@pleunv pleunv commented Aug 17, 2016

Fix for the changed default export behavior in babel 6. The default export now needs to be explicitly required(). See also http://stackoverflow.com/questions/33505992/babel-6-changes-how-it-exports-default.

Had a look at the other examples, they're all ok.

@taion
Copy link
Contributor

taion commented Aug 17, 2016

It'd be better to export with module.exports there.

@taion
Copy link
Contributor

taion commented Aug 19, 2016

@pleunv Can you fix this to use module.exports instead of export default in the modules that are imported via require?

Fix for the changed default export behavior in babel 6.

Fix auth-with-shared-root example
@pleunv
Copy link
Contributor Author

pleunv commented Aug 19, 2016

That should do it

@taion
Copy link
Contributor

taion commented Aug 19, 2016

Thanks!

@taion taion closed this Aug 19, 2016
@taion taion reopened this Aug 19, 2016
@timdorr
Copy link
Member

timdorr commented Aug 19, 2016

👍 Thanks!

@taion taion merged commit c6ac651 into remix-run:master Aug 19, 2016
@taion
Copy link
Contributor

taion commented Aug 19, 2016

Buttons. How do they work.

@timdorr
Copy link
Member

timdorr commented Aug 19, 2016

Oh what the what.

@pleunv pleunv deleted the fix-examples branch August 19, 2016 16:49
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants