Fix ambiguous Miss component not rendering (#3957) #3980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miss would not render in ambiguous match example after navigating away and returning to ambiguous path
TimothyKrell
force-pushed
the
ambiguous-matches-fix
branch
from
0e26c91 to
def641a
Compare
|
I'm going to merge this in as-is, since it's high quality and fixes a notable bug on the website. I don't see the point to the optimization, since React is just going to enqueue Miss's setStates anyways, so there's no extraneous rendering. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miss would not render in ambiguous match example after navigating away and returning to ambiguous path
closes #3957