provided HashRouter with own createHref implementation

[herrkris]

I added an extra function since the link looks different when using hashType hashbang.

This is a fix for #4022. I hope I'm doing it the right way, since this is more or less my first PR.
Help appreciated, especially if it needs tests :)

[timdorr]

Can you add some tests? Thanks!

[ryanflorence]

Can't we just send along the prop given to HashRouter to HashHistory? I'm probably missing something, I haven't looked at the hash stuff recently.

[alisd23]

The issue here is not the url which is pushed to history, that works fine. It's the href on the Link component's a element - https://github.com/ReactTraining/react-router/blob/v4/modules/Link.js#L98.

It fixes browser behaviour such as right-click -> open in new tab, which before would take you to the wrong url.

[timdorr]

LGTM. Thanks for the tests!

[ryanflorence]

https://github.com/ReactTraining/react-history/blob/master/modules/HashHistory.js#L19-L21

Looks like we need cases for hashbang, noslash, and slash.

[alisd23]

Provide cases for hashbang, noslash, and slash

[herrkris]

I imported two functions from the history/PathUtils : stripLeadingSlash and addLeadingSlash.

I don't know if this is the best solution since the LocationUtils.js imports two functions from react-history/PathUtils which itself just exports parsePath and createPath from history/PathUtils.

Perhaps we can also add the two methods to react-history/PathUtils export?

I hope that makes sense somehow ...

[alisd23]

I think what you did makes sense, we know history is always going to be a dependency. Looks good to me now 👍

[ryanflorence]

history is fine, I'm actually killing react-history this week.

[ryanflorence]

Thanks @herrkris 🏆