Don't pass 'undefined' for missing optional parameters
#4064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decodeURIComponent(undefined) is "undefined"
jochenberger
commented
Oct 19, 2016
| location={{ pathname: '/foo' }} | ||
| component={(props) => { | ||
| expect(props).toEqual({ | ||
| params: { foo: 'foo', bar: undefined }, |
There was a problem hiding this comment.
Or do we rather expect { foo: 'foo' } here, without the bar key?
| @@ -23,7 +23,7 @@ const getMatcher = (pattern, exactly) => { | |||
|
|
|||
| const parseParams = (pattern, match, keys) => | |||
| match.slice(1).reduce((params, value, index) => { | |||
There was a problem hiding this comment.
we may want to add filter(value => value !== undefined) before the reduce call to prevent "missing" params to be defined as param properties at all.
jochenberger
commented
Oct 19, 2016
| @@ -23,7 +23,7 @@ const getMatcher = (pattern, exactly) => { | |||
|
|
|||
| const parseParams = (pattern, match, keys) => | |||
| match.slice(1).reduce((params, value, index) => { | |||
| params[keys[index].name] = decodeURIComponent(value) | |||
| params[keys[index].name] = value === undefined ? undefined : decodeURIComponent(value) | |||
There was a problem hiding this comment.
... and leave this modification out
jochenberger
changed the title
undefined'undefined' for missing optional parameters
|
PR updated |
|
Is this getting released soon? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decodeURIComponent(undefined)is"undefined"