Skip to content

Fix missing StaticRouter #4389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2017
Merged

Fix missing StaticRouter #4389

merged 1 commit into from
Jan 30, 2017

Conversation

supasate
Copy link
Contributor

Fix #4387

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v4@993e22a).

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 993e22a...3277632. Read the comment docs.

@timdorr
Copy link
Member

timdorr commented Jan 30, 2017

LGTM. Thanks!

@timdorr timdorr merged commit d23adb0 into remix-run:v4 Jan 30, 2017
@timdorr timdorr mentioned this pull request Jan 30, 2017
Closed
@supasate supasate deleted the fix-missing-static-router branch January 30, 2017 18:20
@zackify
Copy link

zackify commented Jan 30, 2017

Any eta on the publish to npm? Thanks for this fix!

@supasate supasate mentioned this pull request Jan 30, 2017
Merged
@xzilja xzilja mentioned this pull request Jan 30, 2017
Closed
@supasate
Copy link
Contributor Author

@zackify It was already published with [email protected] (not tagged yet but on npm now).

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@supasate @codecov-io @timdorr @zackify