Skip to content

Fix NavLink location variable #4403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2017
Merged

Fix NavLink location variable #4403

merged 1 commit into from
Jan 31, 2017

Conversation

terrierscript
Copy link

I try use NavLink and found isActive error that history is undefined.

I think may NavLink is not public yet.
If this PR is unnecessary, please close it.

@pshrmn pshrmn mentioned this pull request Jan 31, 2017
Closed
@timdorr
Copy link
Member

timdorr commented Jan 31, 2017

Thanks!

@timdorr timdorr merged commit e3cc25a into remix-run:v4 Jan 31, 2017
@mjackson
Copy link
Member

Thanks, @inuscript!

@mjackson
Copy link
Member

(We should probably go fill in those inactive test stubs now! 😅)

@terrierscript terrierscript deleted the fix-nav-location branch January 31, 2017 22:46
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terrierscript @timdorr @mjackson