Skip to content

Use boolean strings for cache keys #4448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2017
Merged

Use boolean strings for cache keys #4448

merged 2 commits into from
Feb 4, 2017

Conversation

pshrmn
Copy link
Contributor

@pshrmn pshrmn commented Feb 3, 2017

Previously, the cache keys for compiled path-to-regexp patterns was being computed using:

const cacheKey = options.end + options.strict

However, this meant that { end: true, strict: false } created the same key as { end: false, strict: true }.

@pshrmn pshrmn mentioned this pull request Feb 3, 2017
@mjackson
Copy link
Member

mjackson commented Feb 4, 2017

Oh man, I thought true + false would be truefalse. Thanks for catching this :)

@mjackson mjackson merged commit 349119a into remix-run:v4 Feb 4, 2017
@pshrmn pshrmn deleted the cache-fix branch February 4, 2017 02:47
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants