Warn when Router is given >1 children
#4450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per issue remix-run#4444, this PR adds an invariant which provides a nicer error message from `Router` if it is given multiple children.
pshrmn
reviewed
Feb 3, 2017
| @@ -21,6 +22,11 @@ class Router extends React.Component { | |||
|
|
|||
| render() { | |||
| const { children } = this.props | |||
| invariant( | |||
| children == undefined || React.Children.count(children) === 1, | |||
| 'A <Router> must have at most one child element.' | |||
There was a problem hiding this comment.
The phrase must have at most sounds odd to me. I think that A <Router> can only have one child element. would be clearer.
There was a problem hiding this comment.
Yeah, I would agree that that could be rephrased. I like yours better. Will see what everyone else thinks but happy to reword.
There was a problem hiding this comment.
Let's say A <Router> may have only one child element
mjackson
requested changes
Feb 4, 2017
|
@mjackson done! 🎉 |
|
@mjackson the tests work locally - not sure why they have failed on Travis :/ |
|
Thanks, @jackfranklin! We'll get those Travis tests worked out soon, don't you worry ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #4444, this PR adds an invariant which provides a nicer
error message from
Routerif it is given multiple children.Any feedback on the approach, etc, is very welcome! I hope it's OK :)