Skip to content

NavLink exact & strict tests #4454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2017
Merged

NavLink exact & strict tests #4454

merged 1 commit into from
Feb 4, 2017

Conversation

pshrmn
Copy link
Contributor

@pshrmn pshrmn commented Feb 3, 2017

Added tests to ensure that the exact and strict props style active as expected.

Also simplified the isActive tests.

@mjackson
Copy link
Member

mjackson commented Feb 4, 2017

💕 Thank you, @pshrmn!

@mjackson mjackson merged commit 61120f6 into remix-run:v4 Feb 4, 2017
@pshrmn pshrmn deleted the navlink-exact-strict branch February 4, 2017 02:46
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pshrmn @mjackson