Only nullify empty children array #4475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdorr
requested changes
Feb 6, 2017
| @@ -19,7 +19,7 @@ class Route extends React.Component { | |||
| const { component, render, match } = props // eslint-disable-line react/prop-types | |||
| let children = props.children // eslint-disable-line react/prop-types | |||
|
|
|||
| if (children && !children.length) children = null | |||
| if (children && Array.isArray(children) && !children.length) children = null | |||
There was a problem hiding this comment.
Actually, you can just make this if (Array.isArray(children) && !children.length) children = null
pshrmn
force-pushed
the
think-of-the-children
branch
from
8136f89 to
30eb965
Compare
|
Thanks for another great PR, @pshrmn! 😍 those tests! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4423 added Preact support by making
childrennull if its length is zero.Function.lengthindicates how many arguments the function takes, so a function that takes no arguments has a length of 0.This PR will make sure that
childrenis an array before setting it tonullwhen it is empty.I also took the liberty of adding some basic
<Route>tests for itscomponent,render, andchildrenprops.