Skip to content

Reimplement tests from #5142 #5965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2018
Merged

Reimplement tests from #5142 #5965

merged 1 commit into from
Feb 22, 2018

Conversation

penx
Copy link
Contributor

@penx penx commented Feb 22, 2018

Further to PR #5142 and subsequent fix in #5964, reimplementing the original unit tests I wrote

@penx penx changed the title reimplement tests from #5142 Reimplement tests from #5142 Feb 22, 2018
@timdorr
Copy link
Member

timdorr commented Feb 22, 2018 •
edited
Loading

Thanks!

@timdorr timdorr merged commit 4a28213 into remix-run:master Feb 22, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@penx @timdorr