Skip to content

chore: add frontmatter to examples for website #8218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 9, 2021

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Nov 4, 2021

closes REM-471

@mcansh mcansh force-pushed the logan/rem-471-add-examples-to-db branch from b0a07a6 to 6201e06 Compare November 4, 2021 16:25
@mcansh mcansh requested a review from ryanflorence November 5, 2021 15:45
@mcansh mcansh changed the title chore: add title to frontmatter so we can add examples to the database on the website chore: add frontmatter to examples for website Nov 9, 2021
@mcansh mcansh merged commit 30caa39 into main Nov 9, 2021
@mcansh mcansh deleted the logan/rem-471-add-examples-to-db branch November 9, 2021 17:02
@timdorr
Copy link
Member

timdorr commented Nov 9, 2021

Hey @mcansh, it looks like this knocked all the examples off the website. Should we revert or try to fix the website build?

@mcansh
Copy link
Collaborator Author

mcansh commented Nov 9, 2021

Hey @mcansh, it looks like this knocked all the examples off the website. Should we revert or try to fix the website build?

cutting a build to bring them back now! Had some website changes so examples are auto added to the website

@mcansh
Copy link
Collaborator Author

mcansh commented Nov 9, 2021

they're back! https://reactrouter.com/docs/en/v6/examples

@timdorr
Copy link
Member

timdorr commented Nov 9, 2021

@mcansh I'm actually getting a 404 on all docs pages now :|

@mcansh
Copy link
Collaborator Author

mcansh commented Nov 9, 2021

@timdorr yeah.. we're not exactly sure what happened there... worked when I sent the message, then somewhere between that and 6.0.2 they all got deleted - keeping an eye on it 👍

brophdawg11 pushed a commit that referenced this pull request Mar 27, 2024
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants