Skip to content

doc: Update StackBlitz link #9596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2022
Merged

doc: Update StackBlitz link #9596

merged 2 commits into from
Nov 15, 2022

Conversation

kiliman
Copy link
Contributor

@kiliman kiliman commented Nov 15, 2022

The link referenced the old remixing branch before the data features were merged into dev.

Fixes #9594

The link referenced the old *remixing* branch before the data features were merged into *dev*.

Fixes #9594
@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2022

⚠️ No Changeset found

Latest commit: 5e5cf8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 15, 2022

Hi @kiliman,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 15, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@kiliman
Copy link
Contributor Author

kiliman commented Nov 15, 2022

Sorry.. didn't realize I had some permissions in the react-router repo, so my patch branch was created here instead of in a fork. Anyway, once this is merged in, we can delete that branch so it doesn't clutter the branch list.

@mcansh mcansh merged commit 0f9bc68 into dev Nov 15, 2022
@mcansh mcansh deleted the kiliman-patch-1 branch November 15, 2022 15:16
@machour
Copy link
Contributor

machour commented Nov 15, 2022

@kiliman still better than your first time on the remix repo 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants