Skip to content

docs(guide/deferred): Fixed code highlights in details element #9612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2022

Conversation

DigitalNaut
Copy link
Contributor

"useAsyncValue" hook alternative example code was missing its highlights.

I tried my best to keep it consistent with the other examples but please review!

"useAsyncValue" hook example code was missing its highlights
@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2022

⚠️ No Changeset found

Latest commit: 8eac612

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 18, 2022

Hi @DigitalNaut,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 18, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Copy link
Contributor

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DigitalNaut and thank you for opening this PR!

I gave it a thorough look, and I think I'd do [11, 16, 23-31] instead to highlight things like this:

Screen Shot 2022-11-18 at 5 32 01 PM

We would be just highlighting the changes from the previous code, while still highlighting the useDataLoader()

What do you think?

@machour machour added the docs label Nov 18, 2022
Only highlighting code that changes from the previous example
@DigitalNaut
Copy link
Contributor Author

I think you're right, I like that better. I've updated the commit with your suggestion instead.

@machour machour changed the title Fixed code highlights in details element in "Deferred Data" guide docs(guide/deferred): Fixed code highlights in details element Nov 18, 2022
@machour machour merged commit f3d3e05 into remix-run:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants