Skip to content

Blog post explaining new variant runtime representation #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 17, 2023

Conversation

zth
Copy link
Collaborator

@zth zth commented Apr 12, 2023

No description provided.

@zth zth marked this pull request as ready for review April 14, 2023 20:05
@ryyppy
Copy link
Member

ryyppy commented Apr 15, 2023

Very good post! Only suggestion I'd have is to shorten the intro (two new features in v11, X and Y, this post will explain why they are important) and proceed with the sections that contain the code snippets and practical use cases.

@zth
Copy link
Collaborator Author

zth commented Apr 15, 2023

@ryyppy thank you! So essentially remove the TLDR; and shorten the intro?

Copy link
Member

@ryyppy ryyppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided some comments but obv. these are just notes on what I'd probably shorten. Not a blocker.

@zth
Copy link
Collaborator Author

zth commented Apr 15, 2023

@ryyppy thank you for the feedback! I've reworked the post according to your comments. Could you have a look again?

@ryyppy
Copy link
Member

ryyppy commented Apr 16, 2023

@zth Thanks, way better now 👏

Co-authored-by: Christoph Knittel <[email protected]>
@zth zth merged commit 1e8ff10 into master Apr 17, 2023
@zth zth deleted the new-variant-representation-blogpost branch April 17, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants