Skip to content

[Docs] Try Gitbook! #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2016
Merged

[Docs] Try Gitbook! #387

merged 1 commit into from
May 20, 2016

Conversation

chenglou
Copy link
Member

@chenglou chenglou commented May 19, 2016

The docs pages reminded me of the Gitbook format, except with the latter, you wouldn't need to maintain anything yourself.

Here's an example of such doc: http://redux.js.org

npm run watch is all you need to set up a watcher that live reflects your changes to localhost:4000. npm run build to publish into _book, which I put into .gitignore, as I'm not sure how publishing to gh-pages work.

Here's a live preview of the book =).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 50.616% when pulling 321bca5 on chenglou:gitbook into 92602a3 on bloomberg:master.




```sh
npm install bs-platform --save
Copy link
Member Author

@chenglou chenglou May 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, a bit of noise here introduced by my editor's setting of trimming dangling whitespace. Whitespace-less diff view: https://github.com/bloomberg/bucklescript/pull/387/files?w=1

@bobzhang
Copy link
Member

this looks great except do we have to remove files in dist to make gitbook happy?

@chenglou
Copy link
Member Author

No we don't. There's just no need anymore for any of the things in dist/ except images, so I singled the latter out.

@bobzhang
Copy link
Member

can you keep it for this commit, I will remove it once I get familiar with gitbook, thanks

The docs pages reminded me of the
[Gitbook](https://github.com/GitbookIO/gitbook) format, except with the latter, you wouldn't need to maintain anything yourself.

Here's an example of such doc: http://redux.js.org

`npm run watch` is all you need to set up a watcher that live reflects your changes to localhost:4000. `npm run build` to publish into _book, which I put into .gitignore, as I'm not sure how publishing to gh-pages work.
@chenglou
Copy link
Member Author

Sure thing. I've restored dist/ and pointed the image link from Why-bucklescript-matters-for-Javascript-platform.md back to dist/images/compile-time.png. The cool thing about gitbook is that it warns you of inexistent URLs, which is how I caught and fixed the misc URLs in this diff.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 50.616% when pulling 96bd413 on chenglou:gitbook into 746024e on bloomberg:master.

@bobzhang
Copy link
Member

Thank you!

@bobzhang bobzhang merged commit da736d4 into rescript-lang:master May 20, 2016
@chenglou chenglou deleted the gitbook branch May 20, 2016 04:07
kevinbarabash pushed a commit to kevinbarabash/rescript-compiler that referenced this pull request Dec 24, 2021
…xternal_garbage

not display external garbage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants