Make CI tests actually fail if there is an error in build_tests; fix broken tests #6804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cknitt
changed the title
cknitt
changed the title
cknitt
commented
Jun 1, 2024
| @@ -44,7 +44,7 @@ async function exec(command, args, options) { | |||
| code = signals[signal] + 128; | |||
| } | |||
|
|
|||
| resolve({ code, stdout, stderr }); | |||
| resolve({ status: code, stdout, stderr }); | |||
There was a problem hiding this comment.
The cli_help tests use status, not code (matching the spawnSync API).
fhammerschmidt
approved these changes
Jun 1, 2024
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.