Skip to content

Fix Obj.magic, String.length etc. appearing in JS output #7087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Oct 6, 2024

User code is usually compiled without -bs-cross-module-opt and therefore needs to be able to directly access the external definitions.

This will also be relevant for the tests as soon as we disable -bs-cross-module-opt there.

@cknitt cknitt marked this pull request as ready for review October 6, 2024 12:29
@cknitt cknitt requested review from cometkim and cristianoc October 6, 2024 12:29
@cknitt cknitt merged commit 7372be9 into rescript-lang:master Oct 7, 2024
20 checks passed
@cknitt cknitt deleted the fix-externals branch October 7, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants