small enhancement to cross inlining: TODO: 1. add comments if we can,… #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,7 +20,7 @@ function force_lazy_block(blk) { | |||
| try { | |||
| var result = closure(/* () */0); | |||
| blk[0] = result; | |||
| Caml_obj_runtime.caml_obj_set_tag(blk, Obj.forward_tag); | |||
| Caml_obj_runtime.caml_obj_set_tag(blk, 250); | |||
There was a problem hiding this comment.
- should generate comment
- should have an option to disable cross module optimization
… for example, cross module constants, 2. specialize some functions as early as we can TODO: improve lambda exports
bobzhang
force-pushed
the
small_function
branch
from
7969b56 to
18b65cc
Compare
bobzhang
added a commit
that referenced
this pull request
Feb 8, 2016
small enhancement to cross inlining: TODO: 1. add comments if we can,…
EduardoRFS
pushed a commit
to EduardoRFS/bucklescript
that referenced
this pull request
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… for example, cross module constants, 2. specialize some functions as early as we can