Skip to content

Add Laravel 8 support #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Conversation

bastien-phi
Copy link

Fixes #102

I tested this locally. It looks like no other change is needed for Laravel 8

@jonnott
Copy link

jonnott commented Sep 8, 2020

Laravel 8 is released today .. how are we doing on getting this reviewed, merged and released?

@bastien-phi @waltjones @coryvirok @ArturMoczulski @emilsundberg @brianr @mrunalk @icsahn-rollbar

@dacoto97
Copy link

dacoto97 commented Sep 8, 2020

@bastien-phi @waltjones @coryvirok @ArturMoczulski @emilsundberg @brianr @mrunalk @icsahn-rollbar
Is there a forecast for the publication of the update ???

Copy link

@letaniaferreira letaniaferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Adding 'prefer-stable' will make sure to use more stable packages than 'dev' if available. https://getcomposer.org/doc/04-schema.md#minimum-stability

@jonnott
Copy link

jonnott commented Sep 9, 2020

Changes look good to me. Adding 'prefer-stable' will make sure to use more stable packages than 'dev' if available. https://getcomposer.org/doc/04-schema.md#minimum-stability

@letaniaferreira Great. Can this be merged and a new version be released asap?

Currently this is preventing users of this lib from upgrading to Laravel 8.x.

@letaniaferreira
Copy link

I will most likely have this out to you by tomorrow @jonnott. I am currently trying to get the right privileges to complete the version update process.

@fgilio
Copy link

fgilio commented Sep 9, 2020

Thanks @letaniaferreira!

@letaniaferreira letaniaferreira merged commit 9ffed90 into rollbar:master Sep 10, 2020
@bastien-phi bastien-phi deleted the support_laravel_8 branch September 10, 2020 17:21
@letaniaferreira
Copy link

Hi @fgilio, @jonnott , @bastien-phi, @ElRochito and @dacoto97, we're still working to get this to Packagist. Did the merge already got you into good shape?

@jonnott
Copy link

jonnott commented Sep 10, 2020

Hi @fgilio, @jonnott , @bastien-phi, @ElRochito and @dacoto97, we're still working to get this to Packagist. Did the merge already got you into good shape?

Getting it onto packagist.org would be 👍

@letaniaferreira
Copy link

Should be good to go: https://packagist.org/packages/rollbar/rollbar-laravel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Laravel 8.x
7 participants