Skip to content

Add support for rollbar-agent #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2021
Merged

Conversation

bishopb
Copy link

@bishopb bishopb commented Mar 21, 2021

Description of the change

The configuration for logging in Laravel requires an instance of Monolog\Handler\HandlerInterface, but the Rollbar library requires a string with value of "agent" to use the agent. This disconnect makes it impossible to use the Rollbar agent with Laravel.

Fixes Issue #85, by way of an adapter class. An example Laravel configuration to use the adapter:

'rollbar' => [
      'driver' => 'monolog',
      'handler' => \Rollbar\Laravel\AgentHandler::class,
      'level' => 'debug',
      'access_token' => env('ROLLBAR_TOKEN'),
      'environment' => 'production'
],

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fixes Issue #85.

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Bishop Bettini added 4 commits March 20, 2021 15:20
It's a by-product of `composer test`, which we don't care to
commit.
Previous commits had been theoretical. Bounced it against a L8
install and adjusted behavior.
Copy link
Member

@brianr brianr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me 👍

Copy link

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bishopb bishopb merged commit 8a24975 into master Mar 28, 2021
@bishopb bishopb mentioned this pull request Mar 28, 2021
@bishopb bishopb deleted the bug/CH-81893/cannot-use-rollbar-agent branch March 28, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants