feat: Lumen test matrix #118
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 24 commits
November 19, 2021 09:53
This is the basic operation: stand up the framework, configure Rollbar within that framework, then invoke a log message. Rig Rollbar so that logged messages get written to a file, that we then check exists and contains the desired value. Later iterations will add the specifics for each framework-version, which may require multiple action files: the setup varies slightly between framework and framework-version.
Never store secrets. Also, by pushing the secret definition into the runner, we have more flexibility for choosing their value based on branch conditions (eg, for testing certain behaviors of various tokens).
The [docs][1] call for `4.*` and `2.*`, so we'll use those to align with the exact documentation. [1]:https://docs.rollbar.com/docs/laravel
Now we'll add them in one at a time, excluding or fixing the bad combo.
Covers Laravel 5.6 through 8, on the appropriate PHP versions from the 7.x series. Comments out a known failing combination of Laravel 5.5 and doesn't include the unlikely to work PHP 8 support.
Hunting down why failing on GitHub action but not local `act`.
The runner is removing leading zeroes, setting the value to '0'.
This failed locally, but it may have been a false negative.
Includes support for confirming the upstream version as well as prototype for testing local when the branching is ready for that.
I understand the approach, but I believe that CI should never fail. It would be better to mark failed tests as skipped/ignored and backlog the failed results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds a test matrix for Lumen, similar to how is done for Laravel in #115. The failures here are all expected, owing to the incorrect handling of
session. As a reminder, this pass is meant to document the current state of the integration: later passes will check master against the relevant versions.Type of change
Related issues
Checklists
Development
Code review