Skip to content

Improved missing typing and comments #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2023
Merged

Improved missing typing and comments #147

merged 2 commits into from
Mar 6, 2023

Conversation

danielmorell
Copy link
Collaborator

Description of the change

This PR does two things...

  1. It adds missing type annotations and comments explaining the methods and their inputs and outputs. This is a BC because it must be respected by any user created class extending one of these.
  2. It moves the $access_token in our test suite from being a dynamically declared property to being defined on the class for compatibility with PHP 8.2.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

None

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added the Type: Maintenance General up-keep, or changes that tidy an existing component or process. label Mar 6, 2023
@danielmorell danielmorell added this to the v8.0.0 milestone Mar 6, 2023
@danielmorell danielmorell requested a review from cyrusradfar March 6, 2023 17:33
waltjones
waltjones approved these changes Mar 6, 2023
View reviewed changes
Copy link

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danielmorell danielmorell merged commit 53224bd into master Mar 6, 2023
@danielmorell danielmorell deleted the updated/types-and-comments branch March 6, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltjones waltjones waltjones approved these changes

@cyrusradfar cyrusradfar Awaiting requested review from cyrusradfar

Assignees
No one assigned
Labels
Type: Maintenance General up-keep, or changes that tidy an existing component or process.
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmorell @waltjones