Skip to content

Fixed #171 Log context passed directly to telemetry body. #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

danielmorell
Copy link
Collaborator

Description of the change

This resolves a bug in how log context is passed to telemetry. It moves the context to a context key in the extra data in the telemetry body.

Without this context array keys that also match telemetry body defined keys could throw type errors if the types don't match.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added this to the v8.1.2 milestone Mar 21, 2025
@danielmorell danielmorell requested a review from brianr March 21, 2025 16:05
@danielmorell danielmorell merged commit 5937631 into master Mar 21, 2025
20 checks passed
@danielmorell danielmorell deleted the fixed/issue-171-log-context-passed-directly-to-telemetry-body branch March 21, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollbar\Payload\TelemetryBody::__construct(): Argument #6 ($stack) must be of type ?string
2 participants