Laravel 6 compatibility

[emilsundberg]

Makes it possible to install this package on Laravel 6

[BrandonSurowiec]

@emilsundberg To make the tests pass RollbarTest.php needs to be updated to use the new signature:

protected function setUp(): void {

}

[BrandonSurowiec]

@ArturMoczulski Laravel 6 was released yesterday. Can we get this PR merged in once ready and a new release tagged?

[jonnott]

+1 for merging this so I can update to L6.0 :)

[emilsundberg]

While you wait it is possible to add my repository in your composer.json

"repositories": [ 
      {
          "type": "vcs",
          "url": "[email protected]:emilsundberg/rollbar-php-laravel.git"
      }
],

and

"require": {
        [..]
        "rollbar/rollbar-laravel": "dev-laravel-6-compatibility"
},

[jonnott]

While you wait it is possible to add my repository in your composer.json

Amazing - that's exactly what I've done :)

[jonnott]

While you wait it is possible to add my repository in your composer.json

Amazing - that's exactly what I've done :)

@emilsundberg However, I now have this problem rollbar/rollbar-php#460
...due to composer resolving to v1.8.0 of https://github.com/rollbar/rollbar-php (which is 'broken')

Seems like we really need Rollbar to pull their finger out and update both these libs :(

[emilsundberg]

@jonnott A temporary fix I use is to requiring monolog/monolog ^1 in my composer.json

"require": {
   [..]
   "monolog/monolog": "^1"
},

[jonnott]

Yes, that’s what I’ve done too!

…

@jonnott A temporary fix I use is to requiring monolog/monolog ^1 in my composer.json "require": { [..] "monolog/monolog": "^1" },

[swilla]

There is anything I can do to help get this PR in shape where it can be merged?

[jonnott]

There is anything I can do to help get this PR in shape where it can be merged?

There is nothing further that needs doing. The Codacy/PR Quality Review is objecting to the Arr::pull() calls - but that's the only way to do it now that the global helper equivalent array_pull() has been removed from Laravel.

Someone from Rollbar just needs to merge the PR, but they're ignoring these threads.

I've even tried asking Rollbar support directly, but to no avail so far.

Please, everyone who needs this merged to update to L6.0, just open a support ticket to Rollbar about it until they pay attention!

[jonnott]

Bugsnag are all over L6.0 compatibility already .. https://github.com/bugsnag/bugsnag-laravel/releases

Time to jump ship?

[wyoumans]

would love to see this merged.

[jonnott]

Think you’ll need to open a support ticket to Rollbar support for them to pay any attention whatsoever..

[ArturMoczulski]

thanks @jonnott for being very adamant on merging this. I'm in the process of getting this released. Should be out soon

[jonnott]

Great, thanks. Having monolog ^2.0 support in rollbar-php would also be a bonus.

rollbar/rollbar-php#460

[Arkanius]

Is this package abandoned? As @jonnott said, time to jump ship?

[emilsundberg]

I got an email from their support yesterday:

Our development team is currently in the process of merging this PR. I can provide you with updates as they become available. We appreciate your patience as we work on this.

[ArturMoczulski]

@jonnott I'll do my best to have the monolog ^2.0 support released as well

@Arkanius as you can see by the popularity of the thread, very much alive :)

[Arkanius]

I'm not sure about ir. This thread has almost 30 days. Some people already forked the repo and added the compatibility. I was just thinking about to drop rollbar and go to another service (sentry, bugsnag)

[jonnott]

I'm not sure about ir. This thread has almost 30 days. Some people already forked the repo and added the compatibility. I was just thinking about to drop rollbar and go to another service (sentry, bugsnag)

@brianr .. the people are voting with their feet :)

[jonnott]

So now it's merged .. how does it get released?

[jopacicdev]

Hi @ArturMoczulski, when can we expect this to be released?

[ArturMoczulski]

@jopacicdev working right now on getting it released asap

[jonnott]

@jopacicdev working right now on getting it released asap

What's stopping it? Does somebody from Rollbar Inc. need to approve it?

[ArturMoczulski]

As you know there are Laravel 6 and Monolog 2 PRs that have been merged. I'm working on having both of those released, but I also need to make sure that the release passes on PHP >= 5.6. Unfortunately, currently, our builds are not passing due to incompatibility between PHP versions, monolog versions and laravel versions. I'm working on making everything green across the build matrix in Travis CI, but it's more complicated than just releasing the packages. I need to fix incompatibilities first.

[jonnott]

@jonnott I'll do my best to have the monolog ^2.0 support released as well

Put in a PR for that here: rollbar/rollbar-php#468

[ArturMoczulski]

Yes, and as you can see in Travis that PR is not passing the builds. So I need to fix the problems with it, as well as problems with the Laravel 6 and PHP versions before I can get it out to the public.

I assure you it's a high priority item we are working on and I'm doing my best to get it out to you as soon as I can

[jonnott]

monolog 1.x requires PHP >=5.3.0

monolog 2.x requires PHP >= 7.2

.. so if a package supports either monolog 1.x OR 2.x, that should all work out, right?

[ArturMoczulski]

Monolog 2 is backward incompatible. That's why it's a major bump version. It means that we need to adjust our code in the SDK to support Monolog 2 while also keeping support for Monolog 1 conditionally depending on what version you are using.

There are also other problems with the builds I'm trying to figure out. There seems to be an incompatibility between Mockery and some of the Monolog handler definitions currently.

[ArturMoczulski]

@jonnott having that said I hugely appreciate your level of effort and engagement in the community behind our SDKs 😄 it's great to see you can't wait to put your hands on the new release. I'll be publishing it as soon as it's ready

[drbyte]

Why not just tag 5.0 which forces the same supported PHP version/s (and monolog) as Laravel 6.0 does?
And then leave the older 4.x/etc versions to work with older PHP and older monolog dependencies?

[ArturMoczulski]

@drbyte that might be the best solution, I've been looking into feasibility of doing this

[ghostal]

Sorry, deleted my previous comment here having found that the issue thread was more recently active.

Was just bemused at requiring tests to pass for PHP >=5.6 when it's no longer supported and the composer.json for 4.x requires PHP >=7.0.

I gather though that Monolog 2.x, as required by Laravel 6, isn't currently supported, and that that's what is currently holding things up. Is that correct?

[ArturMoczulski]

Yes. This merge is dependent on a bigger update to the rollbar-php repo which has been a big task to do and is still not completed. However, it is my number priority right now and should I be able to release very soon. Either by maintaining our current approach of fully supporting PHP >= 5.3 or no. This is currently in debate.

[jonnott]

Can support for both older and newer PHP versions not be achieved with some if statements?

[jonnott]

What I mean is: Make the monolog dependency in rollbar-php be ”^1.0|^2.0” Then in the code say “if” monolog 1.x is loaded, do this ... “else if” 2.x is loaded, do it differently. Therefore you support all PHP versions that either monolog 1.x or 2.x do. If I’m not mistaken, that is exactly the approach the Laravel framework itself is using with monolog at this point (6.x and earlier 5.x versions too?). Solved ...?

[ArturMoczulski]

The differences in between Monolog 1 and Monolog 2 are based on language syntax changes which make the files imparsable by both PHP 5 and PHP 7. Otherwise it would a great suggestion @jonnott

I'm putting together the release right now though, so should be out in a couple of hours

[jonnott]

Ah, that is a pain. Does anyone know if composer has a way of specifying a joint dependency pairing, e.g: php ^5.3 && monolog ^1.0 OR php ^7.0 && monolog ^2.0 Too optimistic? ;)