Removed support for no_std #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos to @jhdcs for implementing support for |
esteve
force-pushed
the
remove-no_std
branch
3 times, most recently
from
b66213c to
6cfa7a6
Compare
jhdcs
previously approved these changes
Apr 19, 2022
|
I think so, if we want to add it back we know how to do that. |
nnmm
reviewed
Apr 19, 2022
nnmm
reviewed
Apr 19, 2022
rclrs/src/error.rs
Outdated
| @@ -613,7 +611,7 @@ impl ToResult for rcl_ret_t { | |||
|
|
|||
| #[cfg(test)] | |||
| mod tests { | |||
| use core::convert::TryFrom; | |||
| use std::convert::TryFrom; | |||
There was a problem hiding this comment.
Should not be needed iirc, since we're on the 2021 Rust edition
nnmm
previously approved these changes
Apr 19, 2022
jhdcs
previously approved these changes
Apr 20, 2022
rclrs/src/error.rs
Outdated
| fmt::{self, Display}, | ||
| }; | ||
| use core_error::{self, Error}; | ||
| use std::convert::TryFrom; |
There was a problem hiding this comment.
If @nnmm is correct about us not needing this for Rust 2021, then this line can be removed as well.
nnmm
previously approved these changes
Apr 21, 2022
nnmm
previously approved these changes
Apr 21, 2022
nnmm
approved these changes
Apr 21, 2022
jhdcs
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes support for
no_std, by removing the dependency for thespincrate and the correspondingcfg()blocks.I recall @nnmm saying that
no_stdis broken (#88 (comment)) and I thought we might as well just remove support for it and revisit this in the future if we want to.