Skip to content

Update Dockerfile #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Update Dockerfile #127

merged 1 commit into from
Apr 26, 2022

Conversation

nnmm
Copy link
Contributor

@nnmm nnmm commented Apr 26, 2022

The new version is significantly simpler.

@nnmm nnmm requested review from esteve and jhdcs April 26, 2022 18:43
Copy link
Collaborator

@jhdcs jhdcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Significantly simpler!

@nnmm nnmm merged commit 04f36d6 into master Apr 26, 2022
@nnmm
Copy link
Contributor Author

nnmm commented Apr 26, 2022

Thanks!

@nnmm nnmm deleted the dockerfile branch April 26, 2022 19:20
@nnmm
Copy link
Contributor Author

nnmm commented Apr 26, 2022

I noticed though that you can no longer choose the ROS distro in the new version. I'll add that back soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants