Add serde support to messages #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhdcs
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
This seems to look all right to me, though I'm hoping @esteve will be able to give a look-through and approval as well before merging. I'm not 100% confident on my CMake skills, for example.
I do like the quickcheck crate - I'll have to look into what all it can do...
esteve
approved these changes
Apr 29, 2022
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation is not the most efficient one possible, except for sequence serialization: It uses
std::string::StringandVecas intermediate formats instead of directly deserializing/serializing to therosidl_runtime_rsdatatype.Closes #115