Skip to content

Generate Cargo.toml of message crate with an EmPy template, not CMake #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2022
Merged

Generate Cargo.toml of message crate with an EmPy template, not CMake #138

merged 2 commits into from
May 2, 2022

Conversation

nnmm
Copy link
Contributor

@nnmm nnmm commented Apr 29, 2022

Closes #114

@esteve esteve self-requested a review May 2, 2022 09:16
esteve
esteve requested changes May 2, 2022
View reviewed changes
esteve
esteve approved these changes May 2, 2022
View reviewed changes
Copy link
Collaborator

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, the less CMake magic we use, the better.

@esteve esteve merged commit 16d2ff3 into master May 2, 2022
@esteve esteve deleted the cargo_toml_empy branch May 2, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esteve esteve esteve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate Cargo.toml of message crate with an EmPy template, not CMake
2 participants
@nnmm @esteve