Add get_domain_id method in Node struct #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace doc comment Co-authored-by: Nikolai Morin <[email protected]>
nnmm
reviewed
May 6, 2022
nnmm
approved these changes
May 6, 2022
|
Thanks for your patient and meaningful suggestions! |
|
Thanks for your contribution @Soya-Onishi! If you want to do something a bit more complex next, how about the node options (#142)? |
|
@nnmm I'll try it, but I think there are what I don't know well , so PR may take more time than this PR. |
|
There is no rush at all, and this issue is just a suggestion, of course. You can also join our Matrix chat, or ask questions in that issue. |
Soya-Onishi
added a commit
to Soya-Onishi/ros2_rust
that referenced
this pull request
May 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #145
This PR add helper method getting ROS domain ID via rcl_get_node_domain_id().
There is TODO in doc, but this should be done after support for passing node option, I think.