Move rclrs_examples to examples/minimal_pub_sub #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhdcs
previously approved these changes
May 13, 2022
|
Thanks for the quick review! I'm giving @esteve a day or so to leave comments since I think he might have some. |
|
Forgot to adapt the README too, done now. |
|
@jhdcs Could you re-review? I realized that I should create a new package for the message demo, since it's not related to pub-sub. |
esteve
approved these changes
May 16, 2022
|
@jhdcs @nnmm what do you think of moving the examples to a separate repo? Like https://github.com/ros2/examples does |
jhdcs
approved these changes
May 16, 2022
|
I think that might be a good idea! It would keep the crate size down, and follow how ROS does things. |
|
I've created https://github.com/ros2-rust/examples, we can move the examples there later once this PR is merged. |
|
I'm fine with a separate repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to add new packages for further examples, which can then go into the
examplesdirectory. I also renamed the package to better follow the naming schema ofrclcppandrclpyexamples.