Make all the things Send, and messages Sync as well #171
Conversation
There was a problem hiding this comment.
Is there a way that we can set up some tests to make sure that our assumptions about Send and Sync on the rcl types are accurate? As in, we set up a few scenarios that can only be done if the external type is truly Send or Sync, and make them part of CI? That way, if something changes within rcl that we don't expect, we don't get caught by surprise - or we can potentially warn rcl if that was not an intended change.
| @@ -213,6 +213,11 @@ macro_rules! string_impl { | |||
| } | |||
| } | |||
|
|
|||
| // SAFETY: A string is a simple data structure, and therefore not thread-specific. | |||
| unsafe impl Send for $string {} | |||
There was a problem hiding this comment.
Forgive the potentially silly question, but I am not familiar with the $string syntax. What does it mean?
There was a problem hiding this comment.
This is inside a macro. $string can be either the String or WString type.
No, not easily. I think maybe (though I haven't checked) it's something that Miri can detect, but setting that up would be a larger undertaking. |
This is required to make multithreading work. For instance, calling publish() on a separate thread doesn't work without these impls.
This is the first time I've needed to implement these traits, but I read up on them and I think this is correct. I believe
rcltypes don't generally care which thread they're on, and therefore can beSend.