Skip to content

Call .ok() immediately after rcl function call #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2022
Merged

Call .ok() immediately after rcl function call #211

merged 1 commit into from
Jul 2, 2022

Conversation

nnmm
Copy link
Contributor

@nnmm nnmm commented Jul 2, 2022

No description provided.

@nnmm nnmm requested a review from a team July 2, 2022 11:18
esteve
esteve previously approved these changes Jul 2, 2022
View reviewed changes
@esteve
Copy link
Collaborator

esteve commented Jul 2, 2022 •
edited
Loading

@nnmm looks good, thanks! It seems that there's a formatting issue, though

@nnmm nnmm force-pushed the call_ok_immediately branch from d609886 to be3311a Compare July 2, 2022 12:53
@nnmm nnmm merged commit a351772 into main Jul 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the call_ok_immediately branch July 2, 2022 13:33
@nnmm
Copy link
Contributor Author

nnmm commented Jul 2, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esteve esteve esteve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nnmm @esteve