Skip to content

Add TYPE_NAME constant to messages and make error fields public #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2022
Merged

Add TYPE_NAME constant to messages and make error fields public #277

merged 1 commit into from
Oct 5, 2022

Conversation

nnmm
Copy link
Contributor

@nnmm nnmm commented Oct 4, 2022

This is required for dynamic messages.

@nnmm nnmm requested a review from a team October 5, 2022 09:57
jhdcs
jhdcs approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@jhdcs jhdcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward enough.

@nnmm nnmm merged commit 3fb8ea5 into main Oct 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the dynamic_messages_1 branch October 5, 2022 11:48
@nnmm
Copy link
Contributor Author

nnmm commented Oct 5, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhdcs jhdcs jhdcs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nnmm @jhdcs