Loadbalancer: closing doesn't subscribe to the underlying #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
***Problem*** Closing the loadbalancer doesn't properly subscribe to the `Publisher`s returned by the `close()` methods of the underlying `ReactiveSocket`. Thus, the close event is lost at the LoadBalancer level. ***Solution*** Properly subscribe to the close `Publisher`s and propagate the `onComplete` events when all `ReactiveSocket` are closed. (I choose to ignore any exception that happened during the close, i.e. only propagate 1 `onComplete`).
| @Override | ||
| public void onError(Throwable t) { | ||
| if (n.decrementAndGet() == 0) { | ||
| subscriber.onComplete(); |
There was a problem hiding this comment.
can propagate the onError to the subscriber here?
EDIT: just saw your description, I think would be nice to log the error so we know if there was an exception.
|
one minor comment, LGTM |
|
|
||
| @Override | ||
| public void onComplete() { | ||
| if (n.decrementAndGet() == 0) { |
There was a problem hiding this comment.
you're doing the same thing in the onComplete and the onError - why not just call onComplete in the onError method?
There was a problem hiding this comment.
Good point, it makes the code simpler.
ilayaperumalg
pushed a commit
to ilayaperumalg/rsocket-java
that referenced
this pull request
Dec 26, 2017
`CONNECTION_CLOSE` error code As discussed in issue rsocket#59 having an error code to indicate "safe closure" similar to GO_AWAY frame in HTTP/2 will be useful to indicate graceful shutdown as opposed to a fatal erro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Problem_
Closing the loadbalancer doesn't properly subscribe to the
Publishersreturned by the
close()methods of the underlyingReactiveSocket.Thus, the close event is lost at the LoadBalancer level.
_Solution_
Properly subscribe to the close
Publishers and propagate theonCompleteevents when all
ReactiveSocketare closed. (I choose to ignore any exceptionthat happened during the close, i.e. only propagate 1
onComplete).