Extract interface Availability
#191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem `DuplexConnection`, `ReactiveSocket` and `ReactiveSocketClient` all provide a method `double availability()` and so can benefit from having a common interface. This will be useful for giving event callbacks that retrieve availability as availability follows a pull model instead of push. #### Modification Added a new interface `AvailabilityProvider` and have the other interfaces extend it. #### Result Common way to access availabilty.
|
\cc @stevegury |
stevegury
reviewed
Nov 8, 2016
|
|
|
@stevegury should we merge for now (I need to move fwd with changes related to events) and revisit the name later? |
NiteshKant
changed the title
AvailabilityProviderAvailability
|
@stevegury I renamed |
|
(For lack of a better word) |
stevegury
approved these changes
Nov 11, 2016
NiteshKant
added a commit
that referenced
this pull request
Dec 8, 2016
* Extract interface `AvailabilityProvider` #### Problem `DuplexConnection`, `ReactiveSocket` and `ReactiveSocketClient` all provide a method `double availability()` and so can benefit from having a common interface. This will be useful for giving event callbacks that retrieve availability as availability follows a pull model instead of push. #### Modification Added a new interface `AvailabilityProvider` and have the other interfaces extend it. #### Result Common way to access availabilty. * Rename `AvailabilityProvider` to `Availability`
NiteshKant
added a commit
to NiteshKant/reactivesocket-java
that referenced
this pull request
Dec 14, 2016
* Extract interface `AvailabilityProvider` `DuplexConnection`, `ReactiveSocket` and `ReactiveSocketClient` all provide a method `double availability()` and so can benefit from having a common interface. This will be useful for giving event callbacks that retrieve availability as availability follows a pull model instead of push. Added a new interface `AvailabilityProvider` and have the other interfaces extend it. Common way to access availabilty. * Rename `AvailabilityProvider` to `Availability`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DuplexConnection,ReactiveSocketandReactiveSocketClientall provide a methoddouble availability()and so can benefit from having a common interface.This will be useful for giving event callbacks that retrieve availability as availability follows a pull model instead of push.
Modification
Added a new interface
AvailabilityProviderand have the other interfaces extend it.Result
Common way to access availabilty.