Respond to keep-alive with response flag off. #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem `ServerReactiveSocket` upon receiving a `KeepAlive` frame responds with a `KeepAlive` frame as an ack. This ack MUST not have respond flag set to true. Doing so will result in an infinite loop of keep-alive frames sent between the peers. #### Modification `ServerReactiveSocket` responds with the respond flag turned off. #### Result No infinite loop of keep-alive frames.
NiteshKant
added a commit
that referenced
this pull request
Dec 8, 2016
#### Problem `ServerReactiveSocket` upon receiving a `KeepAlive` frame responds with a `KeepAlive` frame as an ack. This ack MUST not have respond flag set to true. Doing so will result in an infinite loop of keep-alive frames sent between the peers. #### Modification `ServerReactiveSocket` responds with the respond flag turned off. #### Result No infinite loop of keep-alive frames.
NiteshKant
added a commit
to NiteshKant/reactivesocket-java
that referenced
this pull request
Dec 14, 2016
`ServerReactiveSocket` upon receiving a `KeepAlive` frame responds with a `KeepAlive` frame as an ack. This ack MUST not have respond flag set to true. Doing so will result in an infinite loop of keep-alive frames sent between the peers. `ServerReactiveSocket` responds with the respond flag turned off. No infinite loop of keep-alive frames.
ilayaperumalg
pushed a commit
to ilayaperumalg/rsocket-java
that referenced
this pull request
Dec 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ServerReactiveSocketupon receiving aKeepAliveframe responds with aKeepAliveframe as an ack. This ack MUST not have respond flag set to true. Doing so will result in an infinite loop of keep-alive frames sent between the peers.Modification
ServerReactiveSocketresponds with the respond flag turned off.Result
No infinite loop of keep-alive frames.