Additional flags in Frame.toString()
#197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem Current `Frame.toString()` does not print the various flags associated with different frame types. eg: `requestN` value in `RequestN` frame. This limits the usefulness of frame logging. #### Modifications Added `additionalFlags` string which is generated per frame type. #### Result More insight for frame logging.
yschimke
reviewed
Nov 18, 2016
|
|
||
| switch (type) { | ||
| case LEASE: | ||
| additionalFlags = " Permits: " + Lease.numberOfRequests(this) + ", TTL: " + Lease.ttl(this); |
There was a problem hiding this comment.
This is a bit inconsistent as you don't use , as a separator in the normal toString values
There was a problem hiding this comment.
Aah I didn't notice that. I will fix it in the next change I do
There was a problem hiding this comment.
FYI #198 contains this formatting change.
NiteshKant
added a commit
that referenced
this pull request
Dec 8, 2016
#### Problem Current `Frame.toString()` does not print the various flags associated with different frame types. eg: `requestN` value in `RequestN` frame. This limits the usefulness of frame logging. #### Modifications Added `additionalFlags` string which is generated per frame type. #### Result More insight for frame logging.
ilayaperumalg
pushed a commit
to ilayaperumalg/rsocket-java
that referenced
this pull request
Dec 26, 2017
Based on feedback, adopting the style of description used by HTTP/2 (http://httpwg.org/specs/rfc7540.html#FrameHeader) and specifically showing the first bit of 32-bit and 64-bit numbers to always be 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently
Frame.toString()does not print the various flags associated with different frame types. eg:requestNvalue inRequestNframe. This limits the usefulness of frame logging.Modifications
Added
additionalFlagsstring which is generated per frame type.Result
More insight for frame logging.