Fix to publish Snapshots to jfrog #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem Currently travis is publishing 0.2.3-SNAPSHOT artifacts for 0.5.x branch. #### Modifications I am not 100% sure if this is the correct way to make travis publish the correct version, but it is a way! Modified `buildViaTravis.sh` to override the version, just for snapshot builds. #### Result Correct version number for snapshot.
|
So this fixes the version number. But does this also mean that snapshots are deployed after every commit to JFrog? |
|
@2m the snapshots are built and published via travis today. The only issue is that it is publishing them with the wrong version. This change (hopefully) fixes the version. |
|
FYI: @2m the snapshots are published to JFrog now with 0.5.0-SNAPSHOT name. |
NiteshKant
added a commit
that referenced
this pull request
Dec 8, 2016
#### Problem Currently travis is publishing 0.2.3-SNAPSHOT artifacts for 0.5.x branch. #### Modifications I am not 100% sure if this is the correct way to make travis publish the correct version, but it is a way! Modified `buildViaTravis.sh` to override the version, just for snapshot builds. #### Result Correct version number for snapshot.
NiteshKant
added a commit
to NiteshKant/reactivesocket-java
that referenced
this pull request
Dec 14, 2016
Currently travis is publishing 0.2.3-SNAPSHOT artifacts for 0.5.x branch. I am not 100% sure if this is the correct way to make travis publish the correct version, but it is a way! Modified `buildViaTravis.sh` to override the version, just for snapshot builds. Correct version number for snapshot.
ilayaperumalg
pushed a commit
to ilayaperumalg/rsocket-java
that referenced
this pull request
Dec 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently travis is publishing 0.2.3-SNAPSHOT artifacts for 0.5.x branch.
Modifications
I am not 100% sure if this is the correct way to make travis publish the correct version, but it is a way!
Modified
buildViaTravis.shto override the version, just for snapshot builds.Result
Correct version number for snapshot.