Empty stacktrace of TimeoutException
#202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem `TimeoutPublisher` creates a new `TimeoutException` instance for every timeout. This is costly when the system is under load and has a lot of timers that timeout, which is typical when handling latent outbound services. #### Modification Used a cached `TimeoutException` instance and empty the stacktrace of the exception. #### Result Less overhead of timeouts.
stevegury
reviewed
Dec 7, 2016
| @SuppressWarnings("ThrowableInstanceNeverThrown") | ||
| private static final TimeoutException timeoutException = new TimeoutException(); | ||
|
|
||
| private static final StackTraceElement[] EMPTY_STACK = new StackTraceElement[0]; |
There was a problem hiding this comment.
Rather than setting the stack trace manually, it would be better to override the fillInStacktrace method in all reactivesocket exceptions.
public synchronized Throwable fillInStackTrace() {
return this;
}
There was a problem hiding this comment.
Makes sense. I will update.
BTW, this code is in publishers package and TimeoutException is in core, so this code here uses java.util.concurrent.TimeoutException
|
@stevegury does this look ok now? |
NiteshKant
added a commit
to NiteshKant/reactivesocket-java
that referenced
this pull request
Dec 14, 2016
Empty stacktrace of `TimeoutException` #### Problem `TimeoutPublisher` creates a new `TimeoutException` instance for every timeout. This is costly when the system is under load and has a lot of timers that timeout, which is typical when handling latent outbound services. #### Modification Used a cached `TimeoutException` instance and empty the stacktrace of the exception. #### Result Less overhead of timeouts.
ilayaperumalg
pushed a commit
to ilayaperumalg/rsocket-java
that referenced
this pull request
Dec 26, 2017
Improving the sequence and lifetime docs for channel, and somewhat stream. Specifically this clarifies that COMPLETE is needed in both directions for channel, and how it behaves with ERROR and CANCEL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TimeoutPublishercreates a newTimeoutExceptioninstance for every timeout. This is costly when the system is under load and has a lot of timers that timeout, which is typical when handling latent outbound services.Modification
Used a cached
TimeoutExceptioninstance and empty the stacktrace of the exception.Result
Less overhead of timeouts.