Refactored StressTest for easier configuration
#204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem `StressTest` is pretty useful to do blackbox testing of ReactiveSocket. It is hard to add behavior like leases, keep alive, timeouts, etc. #### Modification Refactored and did the following changes: - Introduced `TestConfig` that is all that needs to be altered to do behavior changes like lease, timeouts, etc. - Changed `StressTest` to use `TestConfig` and only contain the core logic of the test. - Introduced a `StressTestDriver` that contains the creation of config and invocation of `StressTest` #### Result More powerful `StressTest` which can be used for a variety of situations.
|
👍 |
stevegury
approved these changes
Dec 9, 2016
NiteshKant
added a commit
to NiteshKant/reactivesocket-java
that referenced
this pull request
Dec 14, 2016
#### Problem `StressTest` is pretty useful to do blackbox testing of ReactiveSocket. It is hard to add behavior like leases, keep alive, timeouts, etc. #### Modification Refactored and did the following changes: - Introduced `TestConfig` that is all that needs to be altered to do behavior changes like lease, timeouts, etc. - Changed `StressTest` to use `TestConfig` and only contain the core logic of the test. - Introduced a `StressTestDriver` that contains the creation of config and invocation of `StressTest` #### Result More powerful `StressTest` which can be used for a variety of situations.
ilayaperumalg
pushed a commit
to ilayaperumalg/rsocket-java
that referenced
this pull request
Dec 26, 2017
Clarify language about COMPLETE in the frames with (C)omplete, and in the terminology section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
StressTestis pretty useful to do blackbox testing of ReactiveSocket but it is hard to add behavior like leases, keep alive, timeouts, etc.Modification
Refactored and did the following changes:
TestConfigthat is all that needs to be altered to do behavior changes like lease, timeouts, etc.StressTestto useTestConfigand only contain the core logic of the test.StressTestDriverthat contains the creation of config and invocation ofStressTestResult
More powerful
StressTestwhich can be used for a variety of situations.