Duplex interactions #216
Duplex interactions #216
Conversation
#### Problem Duplex interactions (server sending requests to the client) are broken. #### Modification - `ReactiveSocketServer` wasn't using `ClientServerInputMultiplexer` to split input into client and server sockets. This made the responses sent from the client to not reach `ClientReactiveSocket`. Modified `ReactiveSocketServer` to use `ClientServerInputMultiplexer`. - `ClientReactiveSocket` didn't handle a request-stream/channel request before transport subscription arrived. Now using a buffering subscription to buffer request-n and cancel till transport subscription arrives. - Added `DuplexClient` example to demonstrate duplex interactions. #### Result Duplex interactions works!
NiteshKant
requested review from
yschimke,
stevegury,
benjchristensen and
robertroeser
|
\cc @benjchristensen |
|
Since I don't know the surrounding code super well, I have to trust you on most of this. For example, However, it seems to fix the problem so should be merged. |
| Throwable::printStackTrace, | ||
| StreamIdSupplier.serverSupplier(), | ||
| KeepAliveProvider.never()); | ||
| LeaseHonoringSocket lhs = new DefaultLeaseHonoringSocket(sender); |
There was a problem hiding this comment.
The oddity here is that there is no way today in the protocol where a server can tell whether it will honor leases from the client. Probably this should piggy back on the client will honor lease in the setup saying if a client honors lease, server will too.
I am interested in hearing what others think about this.
There was a problem hiding this comment.
@tmontgomery Your input would be useful on this I imagine.
There was a problem hiding this comment.
Does it even make sense for a client responder to use leases? Either it can take requests or it can't (reject/fail). For example, a server-mobile relationship doesn't make sense for leases, as once a mobile client is connected, it only has that one connection to send requests over. Leases really only make sense in server-server situations where a requesting server has multiple connections open and can send requests to different servers depending on their leases.
There was a problem hiding this comment.
I think it's an oversight.
We could decide that the server will match the configuration of the client.
|
👍 |
Revision of how request fragmentation will be done with PAYLOAD frames as per discussion in rsocket/rsocket#198
Problem
Duplex interactions (server sending requests to the client) are broken.
Modification
ReactiveSocketServerwasn't usingClientServerInputMultiplexerto split input into client and server sockets. This made the responses sent from the client to not reachClientReactiveSocket. ModifiedReactiveSocketServerto useClientServerInputMultiplexer.ClientReactiveSocketdidn't handle a request-stream/channel request before transport subscription arrived. Now using a buffering subscription to buffer request-n and cancel till transport subscription arrives.DuplexClientexample to demonstrate duplex interactions.Result
Duplex interactions works!