Server and Client event publishing #217
Conversation
__Problem__ No events are published for `ReactiveSocketClient` __ Modification__ Added event publishing for `ReactiveSocketClient`. __Result__ Events for clients.
__Problem__ No events are published for `ReactiveSocketServer` __ Modification__ Added event publishing for `ReactiveSocketServer`. __Result__ Events for servers.
|
FYI: Since the change was small for the server, I added that to this PR too. |
There was a problem hiding this comment.
This LGTM, and we should merge this.
But I would also like to experiment with the tracing pattern which is less dynamic than your approach but more lightweight, this would allow us to instrument even performance critical piece of code and only pay the price of this when we listen to those specific events.
I plan to do the experiment when I'll have more time.
| @@ -0,0 +1,29 @@ | |||
| /* | |||
| * Copyright 2016 Netflix, Inc. | |||
There was a problem hiding this comment.
Happy new year :)
Looks like a copy-paste otherwise my template has year parameterized.
@stevegury yeah I would be interested in seeing this done differently! |
Client and Server event publishing __Problem__ No events are published for `ReactiveSocketClient` and `ReactiveSocketServer` __ Modification__ Added event publishing for `ReactiveSocketClient` and `ReactiveSocketServer` __Result__ Events for clients and server.
Proposed solution to rsocket/rsocket#210
Problem
No events are published for
ReactiveSocketClientandReactiveSocketServerModification
Added event publishing for
ReactiveSocketClientandReactiveSocketServerResult
Events for clients and servers.
PS: This does not yet add events for
LoadBalancer. I will send a separate PR for that.