Replace servo usage with spectator #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__Problem__ Currently, servo is being used for metric. Spectator is a more generic library and has better APIs. __Modification__ Modified classes to use spectator-api which reduces the code considerably. This is a change required before we layer the events => metric changes. __Result__ Using recommended library at Netflix for metric and lesser code.
ilayaperumalg
pushed a commit
to ilayaperumalg/rsocket-java
that referenced
this pull request
Dec 26, 2017
Include CANCELED in details throughout doc. Clarify wording on error description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, servo is being used for metric. Spectator is a more generic library and has better APIs.
Modification
Modified classes to use spectator-api which reduces the code considerably.
This is a change required before we layer the events => metric changes.
Result
Using recommended library at Netflix for metric and lesser code.